linux-kernel - Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMitSuW2kKAMbPGxCp2k5FECv0yE0978VfGo9thx-q+D_g@mail.gmail.com>
Date:	Wed, 18 Sep 2013 12:24:00 -0700
From:	Olof Johansson <olof@...om.net>
To:	Akhil Bhansali <AkhilAshok.Bhansali@...t.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	kbuild test robot <fengguang.wu@...el.com>,
	OS Engineering <osengineering@...c-inc.com>,
	Ramprasad Chinthekindi <Ramprasad.Chinthekindi@...t.com>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Amit Phansalkar <Amit.Phansalkar@...t.com>
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
 implicit declaration of function 'readq'

On Wed, Sep 18, 2013 at 3:05 AM, Akhil Bhansali
<AkhilAshok.Bhansali@...t.com> wrote:
> Hi Jens,
>
> Please accept this patch that takes care of warnings related to i386 compilation.
> 1. Implicit function declaration of readq and writeq.
> 2. Format related warnings for VPRINTK.
> ----
> From f9964257c83f224c120ecb1e5a7b25e1807efea8 Mon Sep 17 00:00:00 2001
> From: Akhil Bhansali <bhansaliakhil@...il.com>
> Date: Wed, 18 Sep 2013 15:28:39 +0530
> Subject: [PATCH] block: skd: Changes to fix warnings during i386 compilation.
>
> 1. This commit addresses warnings related to
> readq, writeq implicit function declaration.
> 2. Warnings related to mismatched format.
> Signed-off-by: Akhil Bhansali <abhansali@...c-inc.com>
> ---
>  drivers/block/skd_main.c |   19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 773e793..0f25830 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -49,6 +49,7 @@
>  #include <linux/io.h>
>  #include <linux/uaccess.h>
>  #include <asm-generic/unaligned.h>
> +#include <asm-generic/io-64-nonatomic-lo-hi.h>
>
>  #include "skd_s1120.h"
>
> @@ -4557,7 +4558,7 @@ static int skd_cons_skmsg(struct skd_device *skdev)
>         u32 i;
>
>         VPRINTK(skdev, "skmsg_table kzalloc, struct %lu, count %u total %lu\n",
> -               sizeof(struct skd_fitmsg_context),
> +               (unsigned long) sizeof(struct skd_fitmsg_context),

Just change the format string instead, then you don't have to cast
like this everywhere.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/