linux-kernel - Re: [PATCH 46/50] sched: numa: Prevent parallel updates to group stats during placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130920123656.GS12926@twins.programming.kicks-ass.net>
Date:	Fri, 20 Sep 2013 14:36:56 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mel Gorman <mgorman@...e.de>
Cc:	Rik van Riel <riel@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 46/50] sched: numa: Prevent parallel updates to group
 stats during placement

On Fri, Sep 20, 2013 at 01:31:52PM +0100, Mel Gorman wrote:
>  static inline unsigned long group_weight(struct task_struct *p, int nid)
>  {
> +	if (!p->numa_group || !p->numa_group->total_faults)
>  		return 0;
>  
> +	return 1200 * group_faults(p, nid) / p->numa_group->total_faults;
>  }

Unrelated to this change; I recently thought we might want to change
these weight factors based on if the task was predominantly private or
shared.

For shared we use the bigger weight for group, for private we use the
bigger weight for task.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/