linux-kernel - Re: [PATCH 46/50] sched: numa: Prevent parallel updates to group stats during placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130920133130.GY22421@suse.de>
Date:	Fri, 20 Sep 2013 14:31:30 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Rik van Riel <riel@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 46/50] sched: numa: Prevent parallel updates to group
 stats during placement

On Fri, Sep 20, 2013 at 01:31:51PM +0100, Mel Gorman wrote:
> @@ -1402,14 +1394,15 @@ unlock:
>  	if (!join)
>  		return;
>  
> +	double_lock(&my_grp->lock, &grp->lock);
> +
>  	for (i = 0; i < 2*nr_node_ids; i++) {
> -		atomic_long_sub(p->numa_faults[i], &my_grp->faults[i]);
> -		atomic_long_add(p->numa_faults[i], &grp->faults[i]);
> +		my_grp->faults[i] -= p->numa_faults[i];
> +		grp->faults[i] -= p->numa_faults[i];
> +		WARN_ON_ONCE(grp->faults[i] < 0);
>  	}

That stupidity got fixed

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/