linux-kernel - Re: [PATCH v3] mfd: add STw481x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaytQMhPRK59nrXDFhY7e1UyYC3X461-LS-5xymgM36sw@mail.gmail.com>
Date:	Mon, 23 Sep 2013 10:09:53 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wang Shilong <wangshilong1991@...il.com>
Subject: Re: [PATCH v3] mfd: add STw481x driver

On Mon, Sep 23, 2013 at 10:05 AM, Lee Jones <lee.jones@...aro.org> wrote:

> Nit:
>
>> +static const struct i2c_device_id stw481x_id[] = {
>> +     { "stw481x", 0 },
>> +     { }
>
> Where we have '{ }'.
>
>> +};
>> +
>> +static const struct of_device_id stw481x_match[] = {
>> +     { .compatible = "st,stw4810", },
>> +     { .compatible = "st,stw4811", },
>> +     {},
>
> And just down here the same function is provided with '{},'.
>
> I'm happy to change it myself, rather that asking you to resubmit.
>
> Which to you prefer?

Pls fix it if you have time!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/