linux-kernel - Re: [PATCH v3] mfd: add STw481x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130923080532.GD2185@lee--X1>
Date:	Mon, 23 Sep 2013 09:05:32 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	Wang Shilong <wangshilong1991@...il.com>
Subject: Re: [PATCH v3] mfd: add STw481x driver

> This adds a driver for the STw481x PMICs found in the Nomadik
> family of platforms. This one uses pure device tree probing.
> Print some of the OTP registers on boot and register a regulator
> MFD child.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v2->v3:
> - Instead of using "dummy" as the unused device ID, use "stw481x".
> ChangeLog v1->v2:
> - Fix remnant checkpatch errors.
> - #define some more registers to make things clear.
> - Document the power control register access function.
> - Don't free devm_*-allocated devices.
> - Use module_i2c_driver() macro.
> ---
>  drivers/mfd/Kconfig         |  10 ++
>  drivers/mfd/Makefile        |   1 +
>  drivers/mfd/stw481x.c       | 250 ++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/stw481x.h |  56 ++++++++++
>  4 files changed, 317 insertions(+)
>  create mode 100644 drivers/mfd/stw481x.c
>  create mode 100644 include/linux/mfd/stw481x.h

Nit:

> +static const struct i2c_device_id stw481x_id[] = {
> +	{ "stw481x", 0 },
> +	{ }

Where we have '{ }'.

> +};
> +
> +static const struct of_device_id stw481x_match[] = {
> +	{ .compatible = "st,stw4810", },
> +	{ .compatible = "st,stw4811", },
> +	{},

And just down here the same function is provided with '{},'.

I'm happy to change it myself, rather that asking you to resubmit.

Which to you prefer?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/