linux-kernel - Re: [PATCH V2 0/2] Auto stop async-write on block device when device removed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Sep 2013 10:47:53 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	majianpeng <majianpeng@...il.com>
Cc:	axboe <axboe@...nel.dk>, viro <viro@...iv.linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH V2 0/2] Auto stop async-write on block device when device removed.

majianpeng <majianpeng@...il.com> writes:

> For async-write on block device,if device removed,but the vfs don't know it.
> It will continue to do.
> Patch1 set size of inode of block device to zero when removed disk.By this,vfs know 
> disk changed.
> Path2 add size-check on blk_aio_write.If pos of write larger than size of inode,it will
> return zero.So the user can check disk state.

OK, so the basic problem is that __generic_file_aio_write will always
return 0 after device removal, yes?  I'm not sure why that's a real
issue, can you explain exactly why you're trying to change this?

As for your patches, I don't think that putting the i_size_write into
invalidate_partitions is a good idea.  Consider the case of rescanning
partitions: you will always detect a size change now, which is not good.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/