linux-kernel - Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20130923161805.4b4b570241224b673e5c3b1b@linux-foundation.org>
Date:	Mon, 23 Sep 2013 16:18:05 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	iamjoonsoo.kim@....com, rientjes@...gle.com,
	zhangyanfei@...fujitsu.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice

On Tue, 17 Sep 2013 07:29:41 +0800 Wanpeng Li <liwanp@...ux.vnet.ibm.com> wrote:

> >> to set it again in __vmalloc_area_node.
> >> 
> >> Reviewed-by: Zhang Yanfei <zhangyanfei@...fujitsu.com>
> >> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> >> ---
> >>  mm/vmalloc.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >> 
> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> >> index 1074543..d78d117 100644
> >> --- a/mm/vmalloc.c
> >> +++ b/mm/vmalloc.c
> >> @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
> >>  		pages = kmalloc_node(array_size, nested_gfp, node);
> >>  	}
> >>  	area->pages = pages;
> >> -	area->caller = caller;
> >>  	if (!area->pages) {
> >>  		remove_vm_area(area->addr);
> >>  		kfree(area);
> >
> >Then, __vmalloc_area_node() no longer need "caller" argument. It can use area->caller instead.
> >
> 
> Thanks for pointing out, I will update it in next version. 

I've seen so many versions of this patchset that my head has spun right
off.  I'm not at all confident that I have the latest version and I'm
certainly not confident that I've kept up with the ack/nack trail.

So I think I'll drop everything and will await that "next version". 
Please be careful to Cc everyone who was involved and that the
acked/reviewed-by paperwork is up to date.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/