linux-kernel - Re: [PATCH] perf bench: Change the procps visible command-name of invididual benchmark tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52418818.3050308@gmail.com>
Date:	Tue, 24 Sep 2013 06:39:52 -0600
From:	David Ahern <dsahern@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Namhyung Kim <namhyung.kim@....com>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH] perf bench: Change the procps visible command-name of
 invididual benchmark tests

On 9/24/13 4:39 AM, Ingo Molnar wrote:
> +/*
> + * Run a specific benchmark but first rename the running task's ->comm[]
> + * to something meaningful:
> + */
> +static int run_bench(const char *subsys_name, const char *bench_name, bench_fn_t fn, int argc, const char **argv, const char *prefix)

As I recall you are a fan of longer line lengths, but this seems 
excessive. ;-)

---8<---

> +}
> +
> +static void all_suites(struct bench_subsys *subsys)	  /* FROM HERE */

Might as well drop the /* FROM HERE */.

---8<---

> @@ -244,8 +269,7 @@ int cmd_bench(int argc, const char **arg
>   				       subsystems[i].name,
>   				       subsystems[i].suites[j].name);
>   			fflush(stdout);
> -			status = subsystems[i].suites[j].fn(argc - 1,
> -							    argv + 1, prefix);
> +			status = run_bench(subsystems[i].name, subsystems[i].suites[j].name, subsystems[i].suites[j].fn, argc - 1, argv + 1, prefix);

another one that is rather long.

David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/