linux-kernel - Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <52418815.20701@samsung.com>
Date:	Tue, 24 Sep 2013 06:39:49 -0600
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	alex.williamson@...hat.com, Varun.Sethi@...escale.com,
	udknight@...il.com, aik@...abs.ru, rostedt@...dmis.org,
	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, shuahkhan@...il.com,
	Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace

On 09/24/2013 04:48 AM, Joerg Roedel wrote:
> On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote:
>> +DEFINE_EVENT(iommu_fault, report_fault,
>> +
>> +	TP_PROTO(struct device *dev, unsigned long iova, int flags),
>> +
>> +	TP_ARGS(dev, iova, flags)
>> +);
>
> I am not entirely happy with the naming. It is better to name the class
> iommu_error and the page-fault event io_page_fault. This makes it more
> clear what kind of fault it is.
>
>
> 	Joerg
>
>

Joerg,

Yes, iommu_error and io_page_fault sounds better. I will rename and send 
the updated patch.

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/