linux-kernel - Re: checkpatch guide for newbies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5241DEEF.5060509@ahsoftware.de>
Date:	Tue, 24 Sep 2013 20:50:23 +0200
From:	Alexander Holler <holler@...oftware.de>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	kernel-janitors@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch guide for newbies

Am 24.09.2013 19:43, schrieb Alexander Holler:
> Am 24.09.2013 19:26, schrieb Alexander Holler:
>> Am 24.09.2013 18:36, schrieb Bjorn Helgaas:
>>> On Mon, Sep 23, 2013 at 3:01 AM, Dan Carpenter
>>> <dan.carpenter@...cle.com> wrote:
>>>>                  Long Lines
>>>>
>>>> Historically screens were 80 characters wide and it was annoying when
>>>> code went
>>>> over the edge.  These days we have larger screens, but we keep the 80
>>>> character
>>>> limit because it forces us to write simpler code.
>>
>> Sorry, but that just isn't true and never was. Having a line wide limit
>> of 80 characters while forcing tabs to be 8 characters long limits most
>> code to just 72 characters. And even less (max 64) inside constructs
>> like if, for or while.
>>
>> The only outcome of that totally silly rule is that variable names will
>> become shorted to silly acronyms almost nobody does understand make code
>> unreadable.
>
> I forgot to mention function names, which are often even worse shortened
> than variable names.
>
>>
>> I always feel like beeing in the IT stone age when programmers thought
>> they have to use variable names like a, b and c to save storage, memory
>> or to type less when reading linux kernel code.

Just in case of ...

It isn't my intention to start a discussion about that 80 character 
limit, but justifying it with wrong arguments shouldn't be done.

You could write "'It's there and you have to live with it.", but trying 
to justify it with obviously wrong arguments should not be done.

Code doesn't get more simple by forcing people to use akronymous, 
abrevations or to split lines.

Regards,

Alexander Holler

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/