linux-kernel - Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002b01ceba81$4413aa10$cc3afe30$%han@samsung.com>
Date:	Thu, 26 Sep 2013 15:25:59 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Sachin Kamat' <sachin.kamat@...aro.org>
Cc:	'Mark Brown' <broonie@...nel.org>,
	'Liam Girdwood' <lgirdwood@...il.com>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Steve Twiss' <stwiss.opensource@...semi.com>,
	'David Dajun Chen' <david.chen@...semi.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator_register()

On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote:
> On 26 September 2013 07:35, Jingoo Han <jg1.han@...sung.com> wrote:
> > Use devm_regulator_register() to make cleanup paths simpler.
> 
> >         struct fixed_voltage_data *drvdata = platform_get_drvdata(pdev);
> >
> > -       regulator_unregister(drvdata->dev);
> >         kfree(drvdata->desc.supply_name);
> >         kfree(drvdata->desc.name);
> 
> Sorry, couldn't go through all your patches yesterday.
> This one looks a bit scary too as some of the driver data is already
> freed before unregistering.
> 

I looked at regulator_unregister(). I am not sure that this is safe.
So, I will remove this patch from next v3 patch series.
Thank you for your comment. :-)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/