linux-kernel - Re: [PATCH] NFS: Don't use debug-printk-only local variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3222.1380199143@warthog.procyon.org.uk>
Date:	Thu, 26 Sep 2013 13:39:03 +0100
From:	David Howells <dhowells@...hat.com>
To:	Olof Johansson <olof@...om.net>
Cc:	dhowells@...hat.com, Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFS: Don't use debug-printk-only local variables

Olof Johansson <olof@...om.net> wrote:

> -		struct nfs_inode *nfsi = NFS_I(page->mapping->host);
>  		struct fscache_cookie *cookie = nfs_i_fscache(page->mapping->host);
>  
>  		BUG_ON(!cookie);
>  		dfprintk(FSCACHE, "NFS: fscache releasepage (0x%p/0x%p/0x%p)\n",
> -			 cookie, page, nfsi);
> +			 cookie, page, NFS_I(page->mapping->host));

This is really the wrong fix.  The null dfprintk() should use no_printk().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/