lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Sep 2013 08:38:08 -0700 From: Joe Perches <joe@...ches.com> To: David Howells <dhowells@...hat.com> Cc: bfields@...ldses.org, Trond.Myklebust@...app.com, olof@...om.net, linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk() On Thu, 2013-09-26 at 16:35 +0100, David Howells wrote: > Joe Perches <joe@...ches.com> wrote: > > > no_printk doesn't prevent any argument side-effects > > from being optimized away by the compiler. > > > > ie: > > dprintk("%d", func()) > > func is now always called when before it wasn't. > > Yes, I know. There are half a dozen places where this is the case. Those > I've wrapped in ifdebug(FACILITY) { ... } in the code. It's not the nicest, > but at least the compiler always gets to see everything, rather than bits of > it getting hidden by the preprocessor - which means the call points will be > less likely to bit rot over time. No code is eliminated by the preprocessor with the #define I suggest. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists