linux-kernel - Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Sep 2013 15:27:29 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Martin Berglund <martin@...sta.net>
Cc:	teddy.wang@...iconmotion.com.cn, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, wfp5p@...ginia.edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues

On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
>  
>  			/* init SEQ register SR30 - SR75 */
>  			for (i = 0; i < SIZE_SR30_SR75; i++)
> -				if (((i + 0x30) != 0x62) \
> -					&& ((i + 0x30) != 0x6a) \
> -					&& ((i + 0x30) != 0x6b))
> +				if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> +							&& ((i + 0x30) != 0x6b))

The prefered way would be to align this like this:

				if ((i + 0x30) != 0x62 &&
				    (i + 0x30) != 0x6a &&
				    (i + 0x30) != 0x6b)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/