linux-kernel - Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID when the codec is not known

Open Source and information security mailing list archives

Date:	Mon, 30 Sep 2013 11:08:50 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID	when the codec is not known

At Fri, 27 Sep 2013 20:28:03 +0200,
Ondrej Zary wrote:
> 
> Currently, if the codec ID is not known, the last byte of the ID is used as name.
> It's not helpful at all, use full codec ID instead.

The full bytes are already shown at the beginning, no?
It's masked because the upper three bytes are shown in printable form,
and the last byte is usually a model number.

Takashi

> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> ---
>  sound/pci/ac97/ac97_codec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index bf578ba2..30a40a8 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, unsigned int id, char *name, int m
>  				pid->patch(ac97);
>  		}
>  	} else
> -		sprintf(name + strlen(name), " id %x", id & 0xff);
> +		sprintf(name + strlen(name), " id %x", id);
>  }
>  
>  /**
> -- 
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives