linux-kernel - Re: [PATCH] perf auto-dep: Speed up feature tests by building them in parallel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Sep 2013 15:02:47 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	David Ahern <dsahern@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...il.com>
Subject: Re: [PATCH] perf auto-dep: Speed up feature tests by building them
 in parallel

Em Mon, Sep 30, 2013 at 02:46:39PM -0300, Arnaldo Carvalho de Melo escreveu:
> I'm testing removing devel packages, one by one, removing gtk2-devel provides
> the biggest reduction in build time, no surprises :)

And this exercise spotted a but:

make[1]: Leaving directory `/home/git/linux/tools/lib/lk'
    GEN /tmp/build/perf/python/perf.so
Context.xs:22:20: fatal error: EXTERN.h: No such file or directory
compilation terminated.
make: *** [/tmp/build/perf/scripts/perl/Perf-Trace-Util/Context.o] Error 1
make: *** Waiting for unfinished jobs....
util/scripting-engines/trace-event-perl.c:29:20: fatal error: EXTERN.h: No such file or directory
compilation terminated.
make: *** [/tmp/build/perf/util/scripting-engines/trace-event-perl.o] Error 1
make: Leaving directory `/home/git/linux/tools/perf'

 Performance counter stats for 'make -j4 -C tools/perf O=/tmp/build/perf' (3 runs):

       6.453914638 seconds time elapsed                                          ( +- 80.66% )

[acme@zoo linux]$ 
[acme@zoo linux]$

I.e. I did a 'yum remove python-devel', that removed some more packages that
require this package, one of them is needed for perf to build, and this is
not stated on those:

config/Makefile:444: No numa.h found, disables 'perf bench numa mem' benchmark,
please install numa-libs-devel or libnuma-dev


In fact this is why I thought those messages had been missing in your
patchset, they don't appear when I remove perl-devel, i.e. 'perl' supporty
is correctly detected as not possible to build due to missing deps, but
no message is emitted for this case.

And the bug is that the feature test for perl support passes, but since it
doesn't try to use EXTERN.h, like something that is enabled when the feature
test passes (util/scripting-engines/trace-event-perl.c), the build fails.

Notebook battery dying, will continue later...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/