linux-kernel - Re: [PATCH] perf auto-dep: Speed up feature tests by building them in parallel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130930190434.GA3427@gmail.com>
Date:	Mon, 30 Sep 2013 21:04:34 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Ahern <dsahern@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...il.com>
Subject: Re: [PATCH] perf auto-dep: Speed up feature tests by building them
 in parallel


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Em Mon, Sep 30, 2013 at 10:34:27AM -0700, Linus Torvalds escreveu:
> > On Mon, Sep 30, 2013 at 10:12 AM, Arnaldo Carvalho de Melo
> > <acme@...stprotocols.net> wrote:
> > >
> > > Checking why that strlcpy failed...
> > 
> > I don't think glibc does strlcpy. It's not a standard C function, and
> 
> My concern was more about the thinking: ``Is this red "OFF" thing a 
> problem?  I feel so much more confortable when all entries have nice 
> green "on" lights...''

Yeah, so I think we should add our internal implementation of strlcpy() as 
a __weak function instead - if the libc does not provide then we provide a 
fallback.

That should get rid of another ~50 msecs of build overhead, as failed 
feature tests are the most expensive ones.

Agreed?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/