linux-kernel - Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131001224515.GA3113@electric-eye.fr.zoreil.com>
Date:	Wed, 2 Oct 2013 00:45:15 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	"Ruslan N. Marchenko" <me@...f.mobi>, linux-kernel@...r.kernel.org
Subject: Re: [BUG] Regression in 2fdac010
 drivers/net/ethernet/via/via-velocity.c: update napi implementation

Julia Lawall <julia.lawall@...6.fr> :
[...]
> There has already been a discussion about this, and a patch has already 
> been proposed.  It has to do with lock managament.  I will look for the 
> email.

The underlying problem has to do with disabled irq. netif_receive_skb
assumes irq to be enabled. Current via-velocity poll() method should
narrow its (spinlocked) irq disabled section.

What I've done should not require much analysis (aka "what could race
with the rx bh processing in a napi driver ?") and avoids a more intrusive
lockless napi design.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/