linux-kernel - Re: [PATCH v2] Staging : android: binder.c: Prefer seq_puts to seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380686782.2081.28.camel@joe-AO722>
Date:	Tue, 01 Oct 2013 21:06:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mathieu Rhéaume <mathieu@...ingrhemes.com>
Cc:	gregkh@...uxfoundation.org, arve@...roid.com,
	dan.carpenter@...cle.com, mirsal@...sal.fr,
	serban.constantinescu@....com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging : android: binder.c: Prefer seq_puts to
 seq_printf

On Tue, 2013-10-01 at 23:57 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
>  * Fixed the indent problems (2 tab and 1 space) by Joe Perches.
>  * Found more calls to convert from seq_printf to seq_puts
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,33 +3272,33 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
>  static void print_binder_transaction(struct seq_file *m, const char *prefix,
>  				     struct binder_transaction *t)
>  {
> -	seq_printf(m,
> -		   "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
> -		   prefix, t->debug_id, t,
> -		   t->from ? t->from->proc->pid : 0,
> -		   t->from ? t->from->pid : 0,
> -		   t->to_proc ? t->to_proc->pid : 0,
> -		   t->to_thread ? t->to_thread->pid : 0,
> -		   t->code, t->flags, t->priority, t->need_reply);
> +		seq_puts(m, "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",

Only indent the subsequent lines
not the initial seq_puts.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/