linux-kernel - Re: [PATCH] Staging: android: binder.c: Fixed 80 characters warnings from checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131002045749.GA15121@kroah.com>
Date:	Tue, 1 Oct 2013 21:57:49 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Mathieu Rhéaume <mathieu@...ingrhemes.com>,
	arve@...roid.com, dan.carpenter@...cle.com, mirsal@...sal.fr,
	serban.constantinescu@....com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: binder.c: Fixed 80 characters warnings
 from checkpatch.pl

On Tue, Oct 01, 2013 at 06:46:44PM -0700, Joe Perches wrote:
> On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
> > Fixed a lot of warnings from checkpatch.pl about the 80 characters per line limitation.
> 
> I'd prefer
> 	s/binder_user_error/binder_user_err/
> or
> 	s/binder_user_error/binder_err/
> 
> without doing the strange wrapping
> 
> checkpatch will then exclude these long line formats from
> line length checking.
> 
> > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> []
> > @@ -663,7 +663,8 @@ static struct binder_buffer *binder_alloc_buf(struct binder_proc *proc,
> >  		ALIGN(offsets_size, sizeof(void *));
> >  
> >  	if (size < data_size || size < offsets_size) {
> > -		binder_user_error("%d: got transaction with invalid size %zd-%zd\n",
> > +		binder_user_error(
> > +		"%d: got transaction with invalid size %zd-%zd\n",
> >  				proc->pid, data_size, offsets_size);
> 
> IMO - not an improvement
> 

I agree, checkpatch is a guide, not a hard and fast rule.  For stuff
like this, it gets the line length wrong, so it's safe to leave it
alone.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/