linux-kernel - Re: [PATCH] fbdev: sh_mobile_hdmi: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1732816.05cDxPcW7M@avalon>
Date:	Thu, 03 Oct 2013 18:56:47 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Sangjung Woo <sangjung.woo@...sung.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: sh_mobile_hdmi: Use devm_kzalloc()

Hi Sangjung,

Thank you for the patch.

On Thursday 03 October 2013 23:04:27 Sangjung Woo wrote:
> Use devm_kzalloc() instead of kzalloc() in order to be free
> automatically. This makes cleanup paths more simple.
> 
> Signed-off-by: Sangjung Woo <sangjung.woo@...sung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Tomi, could you please pick it up ?

> ---
>  drivers/video/sh_mobile_hdmi.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
> index bfe4728..64bd0bf 100644
> --- a/drivers/video/sh_mobile_hdmi.c
> +++ b/drivers/video/sh_mobile_hdmi.c
> @@ -1290,7 +1290,7 @@ static int __init sh_hdmi_probe(struct platform_device
> *pdev) }
>  	}
> 
> -	hdmi = kzalloc(sizeof(*hdmi), GFP_KERNEL);
> +	hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
>  	if (!hdmi) {
>  		dev_err(&pdev->dev, "Cannot allocate device data\n");
>  		return -ENOMEM;
> @@ -1304,7 +1304,7 @@ static int __init sh_hdmi_probe(struct platform_device
> *pdev) if (IS_ERR(hdmi->hdmi_clk)) {
>  		ret = PTR_ERR(hdmi->hdmi_clk);
>  		dev_err(&pdev->dev, "Unable to get clock: %d\n", ret);
> -		goto egetclk;
> +		return ret;
>  	}
> 
>  	/* select register access functions */
> @@ -1407,8 +1407,6 @@ ereqreg:
>  	clk_disable(hdmi->hdmi_clk);
>  erate:
>  	clk_put(hdmi->hdmi_clk);
> -egetclk:
> -	kfree(hdmi);
> 
>  	return ret;
>  }
> @@ -1433,7 +1431,6 @@ static int __exit sh_hdmi_remove(struct
> platform_device *pdev) iounmap(hdmi->htop1);
>  	iounmap(hdmi->base);
>  	release_mem_region(res->start, resource_size(res));
> -	kfree(hdmi);
> 
>  	return 0;
>  }
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/