linux-kernel - Re: [PATCH 2/2] mm/sparsemem: Fix a bug in free_map_bootmem when CONFIG_SPARSEMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131003134204.e408977b42cb85984473cfd6@linux-foundation.org>
Date:	Thu, 3 Oct 2013 13:42:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Zhang Yanfei <zhangyanfei.yes@...il.com>
Cc:	Wen Congyang <wency@...fujitsu.com>,
	Tang Chen <tangchen@...fujitsu.com>,
	Toshi Kani <toshi.kani@...com>, isimatu.yasuaki@...fujitsu.com,
	Linux MM <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] mm/sparsemem: Fix a bug in free_map_bootmem when
 CONFIG_SPARSEMEM_VMEMMAP

On Thu, 03 Oct 2013 11:32:02 +0800 Zhang Yanfei <zhangyanfei.yes@...il.com> wrote:

> We pass the number of pages which hold page structs of a memory
> section to function free_map_bootmem. This is right when
> !CONFIG_SPARSEMEM_VMEMMAP but wrong when CONFIG_SPARSEMEM_VMEMMAP.
> When CONFIG_SPARSEMEM_VMEMMAP, we should pass the number of pages
> of a memory section to free_map_bootmem.
> 
> So the fix is removing the nr_pages parameter. When
> CONFIG_SPARSEMEM_VMEMMAP, we directly use the prefined marco
> PAGES_PER_SECTION in free_map_bootmem. When !CONFIG_SPARSEMEM_VMEMMAP,
> we calculate page numbers needed to hold the page structs for a
> memory section and use the value in free_map_bootmem.

What were the runtime user-visible effects of that bug?

Please always include this information when fixing a bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/