linux-kernel - Re: [PATCH] perf: Fix failing assertions in perf bench numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131004060227.GC11399@gmail.com>
Date:	Fri, 4 Oct 2013 08:02:27 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Petr Holasek <pholasek@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Jiri Olsa <jolsa@...hat.com>, Petr Benas <pbenas@...hat.com>
Subject: Re: [PATCH] perf: Fix failing assertions in perf bench numa


* Petr Holasek <pholasek@...hat.com> wrote:

> Patch adds more subtle handling of -C and -N parameters in
> parse_{cpu,node}_setup_list() functions when there isn't enough NUMA nodes or
> CPUs present.
> Instead of assertion and terminating benchmark, partial test is skipped
> with error message and perf will continue to the next one.
> 
> Fixed problem can be easily reproduced on machine with only one NUMA node:
> 
>  # Running numa/mem benchmark...
> 
>   # Running main, "perf bench numa mem -a"
> 
> ...
> 
>  # Running RAM-bw-remote, "perf bench numa mem -p 1 -t 1 -P 1024 -C 0 -M 1 -s
> perf: bench/numa.c:622: parse_setup_node_list: Assertion `!(bind_node_0 < 0 ||
> 		bind_node_0 >= g->p.nr_nodes)' failed.
> Aborted
> 
> Signed-off-by: Petr Benas <pbenas@...hat.com>
> Signed-off-by: Petr Holasek <pholasek@...hat.com>

Thanks Petr!

Acked-by: Ingo Molnar <mingo@...nel.org>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/