linux-kernel - [PATCH] blk-mq: fix blk_mq_start_stopped_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131006170956.GA30544@infradead.org>
Date:	Sun, 6 Oct 2013 10:09:56 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] blk-mq: fix blk_mq_start_stopped_hw_queues from irq context

The only caller of blk_mq_start_stopped_hw_queues is in irq context,
leading to lockdep splat when it actually gets called.  Fix this by
deferring the hw queue run to workqueue context.

Signed-off-by: Christoph Hellwig <hch@....de>

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 2b85029..923e9e1 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -686,7 +686,8 @@ void blk_mq_start_stopped_hw_queues(struct request_queue *q)
 		if (!test_bit(BLK_MQ_S_STOPPED, &hctx->state))
 			continue;
 
-		blk_mq_start_hw_queue(hctx);
+		clear_bit(BLK_MQ_S_STOPPED, &hctx->state);
+		blk_mq_run_hw_queue(hctx, true);
 	}
 }
 EXPORT_SYMBOL(blk_mq_start_stopped_hw_queues);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/