[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <184520834.2485938.1381185329449.JavaMail.root@redhat.com>
Date: Mon, 7 Oct 2013 18:35:29 -0400 (EDT)
From: Ben Skeggs <bskeggs@...hat.com>
To: "Geyslan G. Bem" <geyslan@...il.com>
Cc: airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, kernel-br@...glegroups.com
Subject: Re: [PATCH] drm: nouveau: fix nvbe leakage
----- Original Message -----
> From: "Geyslan G. Bem" <geyslan@...il.com>
> To: airlied@...ux.ie, bskeggs@...hat.com, dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org, kernel-br@...glegroups.com, "Geyslan G. Bem" <geyslan@...il.com>
> Sent: Tuesday, 8 October, 2013 8:14:26 AM
> Subject: [PATCH] drm: nouveau: fix nvbe leakage
>
> Free memory allocated to nvbe when returning NULL.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
NACK. ttm_dma_tt_init() calls the destructor if it fails, which frees the memory.
Ben.
> ---
> drivers/gpu/drm/nouveau/nouveau_sgdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> index 0843ebc..af8b66d 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> @@ -105,6 +105,9 @@ nouveau_sgdma_create_ttm(struct ttm_bo_device *bdev,
> nvbe->ttm.ttm.func = &nv50_sgdma_backend;
>
> if (ttm_dma_tt_init(&nvbe->ttm, bdev, size, page_flags, dummy_read_page))
> + {
> + kfree(nvbe);
> return NULL;
> + }
> return &nvbe->ttm.ttm;
> }
> --
> 1.8.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists