linux-kernel - Re: [PATCH] x86: mkpiggy.c: fix resource leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52533782.4050207@zytor.com>
Date:	Mon, 07 Oct 2013 15:36:50 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
CC:	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, kernel-br@...glegroups.com
Subject: Re: [PATCH] x86: mkpiggy.c: fix resource leakage

On 10/07/2013 03:16 PM, Geyslan G. Bem wrote:
> Even though the resource is released when the application is closed or
> when returned from main function, modified to make it in accordance.
> Now FILE pointer is always verified.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>

Perhaps you could explain what problem is solved by this patch?

Note that for correctness we really should check the return value from
fclose().

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/