linux-kernel - Re: [PATCH] checkpatch: Add check for sscanf without return use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1381190594.2081.228.camel@joe-AO722>
Date:	Mon, 07 Oct 2013 17:03:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Add check for sscanf without return use

On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote:
> On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches <joe@...ches.com> wrote:
> 
> > Naked use sscanf can be troublesome.
> 
> It would be helpful to expand on "troublesome"?

Dunno, you either know or the couple of paragraphs
it takes to explain with examples won't really be
too helpful in a commit log.

> > Add a warning when the sscanf return value is not used.
> Maybe it should be __must_check?

Maybe.

That might be easier but there'll be a couple
hundred new build warnings.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/