linux-kernel - Re: [PATCH] perf tools: fix missing default initialization for tool->mmap2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008122805.GB3955@infradead.org>
Date:	Tue, 8 Oct 2013 09:28:05 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mike Galbraith <bitbucket@...ine.de>,
	Peter Zijlstra <peterz@...radead.org>,
	"mingo@...e.hu" <mingo@...e.hu>
Subject: Re: [PATCH] perf tools: fix missing default initialization for
 tool->mmap2

Em Tue, Oct 08, 2013 at 02:02:06PM +0200, Stephane Eranian escreveu:
> On Tue, Oct 8, 2013 at 1:59 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >> --- a/tools/perf/util/session.c
> >> +++ b/tools/perf/util/session.c
> >> @@ -256,6 +256,8 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
> >>               tool->sample = process_event_sample_stub;
> >>       if (tool->mmap == NULL)
> >>               tool->mmap = process_event_stub;
> >> +     if (tool->mmap2 == NULL)
> >> +             tool->mmap2 = process_event_stub;
> >>       if (tool->comm == NULL)
> >>               tool->comm = process_event_stub;
> >>       if (tool->fork == NULL)

> > I think it's already fixed in tip:perf/urgent:

> >   6adb0b0ae26f perf tools: Add default handler for mmap2 events

> Ok, it's good then.
> Thanks for checking.

Yeah, since 'perf sched' doesn't use mmap records, just relying on the
stub default handler is enough.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/