linux-kernel - Re: [PATCH] perf tools: fix missing default initialization for tool->mmap2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Oct 2013 14:02:06 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Mike Galbraith <bitbucket@...ine.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"mingo@...e.hu" <mingo@...e.hu>
Subject: Re: [PATCH] perf tools: fix missing default initialization for tool->mmap2

On Tue, Oct 8, 2013 at 1:59 PM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Stephane Eranian <eranian@...gle.com> wrote:
>
>>
>> This patch fixes a SEGFAULT bug with perf sched
>> related to the new MMAP2 record type. There was
>> a missing default initialization for the tool->mmap2
>> pointer in perf_tool__fill_defaults().
>>
>> Reproducer:
>>  # perf sched record -- sleep 1
>>  # perf sched lat
>>
>> Reported-by: Mike Galbraith <bitbucket@...ine.de>
>> Signed-off-by: Stephane Eranian <eranian@...gle.com>
>> --
>>
>> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
>> index 211b325..8415c54 100644
>> --- a/tools/perf/util/session.c
>> +++ b/tools/perf/util/session.c
>> @@ -256,6 +256,8 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
>>               tool->sample = process_event_sample_stub;
>>       if (tool->mmap == NULL)
>>               tool->mmap = process_event_stub;
>> +     if (tool->mmap2 == NULL)
>> +             tool->mmap2 = process_event_stub;
>>       if (tool->comm == NULL)
>>               tool->comm = process_event_stub;
>>       if (tool->fork == NULL)
>
> I think it's already fixed in tip:perf/urgent:
>
>   6adb0b0ae26f perf tools: Add default handler for mmap2 events
>
Ok, it's good then.
Thanks for checking.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/