linux-kernel - Re: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008174721.GH13128@radagast>
Date:	Tue, 8 Oct 2013 12:47:21 -0500
From:	Felipe Balbi <balbi@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	Nishanth Menon <nm@...com>,
	Benoît Cousson <bcousson@...libre.com>,
	Felipe <balbi@...com>, Olof Johansson <olof@...om.net>,
	<devicetree@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions

Hi,

On Mon, Oct 07, 2013 at 12:20:09PM -0700, Tony Lindgren wrote:
> * Nishanth Menon <nm@...com> [131007 09:57]:
> > beagle-xm currently would matchup with ti,omap3 which invokes
> > omap3430_init_early instead of omap3630_init_early. So add
> > compatiblity for 3630 to allow match
> > 
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> >  arch/arm/boot/dts/omap3-beagle-xm.dts |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > index 0f7cfc5..2079e22 100644
> > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > @@ -11,7 +11,7 @@
> >  
> >  / {
> >  	model = "TI OMAP3 BeagleBoard xM";
> > -	compatible = "ti,omap3-beagle-xm", "ti,omap3-beagle", "ti,omap3";
> > +	compatible = "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3-beagle", "ti,omap3";
> >  
> >  	cpus {
> >  		cpu@0 {
> 
> This compatible string looks hacky.. How about just make it
> 
> "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3";
> 
> How about just leave out "ti,omap3-beagle" here?

ti,omap3-beagle was already part of the original file, we can definitely
remove but I'd expect us to maintain support for that string
indefinitely should anybody continue to use older dtbs.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)