linux-kernel - Re: [PATCH 00/16] sched/wait: Collapse __wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008194718.GD7315@gmail.com>
Date:	Tue, 8 Oct 2013 21:47:18 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo.kernel.org@...il.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] sched/wait: Collapse __wait_event macros -v5


* Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote:

> On Tue, Oct 08, 2013 at 12:23:31PM +0200, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@...radead.org> wrote:
> > 
> > > On Sat, Oct 05, 2013 at 10:04:16AM +0200, Ingo Molnar wrote:
> > > > 
> > > > * Peter Zijlstra <peterz@...radead.org> wrote:
> > > > 
> > > > > On Fri, Oct 04, 2013 at 10:44:05PM +0200, Peter Zijlstra wrote:
> > > > > > 
> > > > > > slightly related; do we want to do something like the following two
> > > > > > patches?
> > > > > 
> > > > > and
> > > > 
> > > > Yeah, both look good to me - but I'd move them into 
> > > > kernel/sched/completion.c and kernel/sched/wait.c if no-one objects.
> > > 
> > > Do you also want to suck in semaphore.c mutex.c rwsem.c spinlock.c etc? 
> > > Or do you want to create something like kernel/locking/ for all that.
> > 
> > Yeah, I think kernel/locking/ would be a suitable place for those, and I'd 
> > move lockdep*.c there too. (Such things are best done near the end of a 
> > merge window, when there's not much pending, to not disrupt development.)
> > 
> > kernel/*.c is a pretty crowded place with 100+ files currently, I've been 
> > gradually working towards depopulating it slowly but surely for subsystems 
> > that I co-maintain or where I'm frequently active. We already have:
> > 
> >   kernel/sched/
> >   kernel/events/
> >   kernel/irq/
> >   kernel/time/
> >   kernel/trace/
> > 
> > and the deeper kernel/*/* hierarchies already host another ~100 .c files. 
> > So the transition is half done already I suspect.
> 
> Should I be thinking about making a kernel/rcu?

I wanted to raise it with you at the KS :-)

To me it would sure look nice to have kernel/rcu/tree.c, 
kernel/rcu/tiny.c, kernel/rcu/core.c, etc.

[ ... and we would certainly also break new ground by introducing a
  "torture.c" file, for the first time in Linux kernel history! ;-) ]

But it's really your call, this is something you should only do if you are 
comfortable with it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/