lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131008220811.GC16625@amt.cnet>
Date:	Tue, 8 Oct 2013 19:08:11 -0300
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	kvm@...r.kernel.org, pbonzini@...hat.com, gleb@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/3] pvclock: detect watchdog reset at pvclock read

On Tue, Oct 08, 2013 at 09:37:05AM -0400, Don Zickus wrote:
> On Mon, Oct 07, 2013 at 10:05:17PM -0300, Marcelo Tosatti wrote:
> > Implement reset of kernel watchdogs at pvclock read time. This avoids
> > adding special code to every watchdog.
> > 
> > This is possible for watchdogs which measure time based on sched_clock() or 
> > ktime_get() variants.
> > 
> > Suggested by Don Zickus.
> > 
> > Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>
> 
> Awesome.  Thanks for figuring this out Marcelo.  Does that mean we can
> revert commit 5d1c0f4a now? :-)

Unfortunately no: soft lockup watchdog does not measure time based on
sched_clock but on hrtimer interrupt count :-(
(see the the softlockup code in question, perhaps you can point to 
something that i'm missing).

BTW, are you OK with printing additional steal time information?
https://lkml.org/lkml/2013/6/27/755

> This meets my expectations.  I'll leave it to the virt folks to figure out
> if this covers all the corner cases or not.
> 
> Cheers,
> Don

Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ