| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <525513E8.6040900@asianux.com> Date: Wed, 09 Oct 2013 16:29:28 +0800 From: Chen Gang <gang.chen@...anux.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> CC: kexec@...ts.infradead.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Al Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Joe Perches <joe@...ches.com>, Richard Weinberger <richard@....at> Subject: [PATCH] kernel/kexec.c: use vscnprintf() instead of vsnprintf() in vmcoreinfo_append_str() vsnprintf() may let 'r' larger than sizeof(buf), in this case, if 'r' is also less than "vmcoreinfo_max_size - vmcoreinfo_size" (left size of destination buffer), next memcpy() will read the unexpected addresses. Signed-off-by: Chen Gang <gang.chen@...anux.com> --- kernel/kexec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index 2a74f30..0abcd68 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -1533,7 +1533,7 @@ void vmcoreinfo_append_str(const char *fmt, ...) size_t r; va_start(args, fmt); - r = vsnprintf(buf, sizeof(buf), fmt, args); + r = vscnprintf(buf, sizeof(buf), fmt, args); va_end(args); r = min(r, vmcoreinfo_max_size - vmcoreinfo_size); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists