lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Oct 2013 14:48:44 +0200 From: Ingo Molnar <mingo@...nel.org> To: Peter Zijlstra <peterz@...radead.org> Cc: Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com>, Andrea Arcangeli <aarcange@...hat.com>, Johannes Weiner <hannes@...xchg.org>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 0/63] Basic scheduler support for automatic NUMA balancing V9 * Peter Zijlstra <peterz@...radead.org> wrote: > On Wed, Oct 09, 2013 at 01:03:54PM +0200, Ingo Molnar wrote: > > kernel/sched/fair.c:819:22: warning: 'task_h_load' declared 'static' but never defined [-Wunused-function] > > Not too pretty, but it avoids the warning: > > --- > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -681,6 +681,8 @@ static u64 sched_vslice(struct cfs_rq *c > } > > #ifdef CONFIG_SMP > +static unsigned long task_h_load(struct task_struct *p); > + > static inline void __update_task_entity_contrib(struct sched_entity *se); > > /* Give new task start runnable values to heavy its load in infant time */ > @@ -816,8 +818,6 @@ update_stats_curr_start(struct cfs_rq *c > * Scheduling class queueing methods: > */ > > -static unsigned long task_h_load(struct task_struct *p); > - > #ifdef CONFIG_NUMA_BALANCING Hm, so we really want to do a split-up of this file once things have calmed down - that will address such dependency issues. Until then this fix will do, I've backmerged it to the originating patch. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists