linux-kernel - Re: [PATCH] kvm fix: Enable pvspinlock after jump_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525A5519.2050205@linux.vnet.ibm.com>
Date:	Sun, 13 Oct 2013 13:38:57 +0530
From:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
To:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de
CC:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>,
	x86@...nel.org, gleb@...hat.com, pbonzini@...hat.com,
	konrad.wilk@...cle.com, habanero@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	mtosatti@...hat.com, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] kvm fix: Enable pvspinlock after jump_label_init() to
 avoid VM hang

On 10/09/2013 02:33 PM, Raghavendra K T wrote:
> We use jump label to enable pv-spinlock. With the changes in
> (442e0973e927 Merge branch 'x86/jumplabel'), the jump label behaviour has changed
> that would result in evntual hang of the VM since we would end up in a situation
> where slowpath locks would halt the vcpus but we will not be able to wakeup the
> vcpu by lock releaser using unlock kick.
>
> Similar problem in Xen and more detailed description is available in
> a945928ea270 (xen: Do not enable spinlocks before jump_label_init() has executed)
>
> This patch splits kvm_spinlock_init to separate jump label changes with pvops
> patching and also make jump label enabling after jump_label_init().
>
> Signed-off-by: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>

Ingo,
Could you please take this fix?
This is reviewed by Paolo and Steven.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/