linux-kernel - Re: [PATCH] kvm fix: Enable pvspinlock after jump_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131013081059.GA15657@redhat.com>
Date:	Sun, 13 Oct 2013 11:11:00 +0300
From:	Gleb Natapov <gleb@...hat.com>
To:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
Cc:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	x86@...nel.org, pbonzini@...hat.com, konrad.wilk@...cle.com,
	habanero@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, mtosatti@...hat.com,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] kvm fix: Enable pvspinlock after jump_label_init() to
 avoid VM hang

On Sun, Oct 13, 2013 at 01:38:57PM +0530, Raghavendra K T wrote:
> On 10/09/2013 02:33 PM, Raghavendra K T wrote:
> >We use jump label to enable pv-spinlock. With the changes in
> >(442e0973e927 Merge branch 'x86/jumplabel'), the jump label behaviour has changed
> >that would result in evntual hang of the VM since we would end up in a situation
> >where slowpath locks would halt the vcpus but we will not be able to wakeup the
> >vcpu by lock releaser using unlock kick.
> >
> >Similar problem in Xen and more detailed description is available in
> >a945928ea270 (xen: Do not enable spinlocks before jump_label_init() has executed)
> >
> >This patch splits kvm_spinlock_init to separate jump label changes with pvops
> >patching and also make jump label enabling after jump_label_init().
> >
> >Signed-off-by: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
> 
> Ingo,
> Could you please take this fix?
> This is reviewed by Paolo and Steven.
It's KVM, I'll take it.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/