linux-kernel - Re: [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Oct 2013 17:32:08 -0300
From:	Geyslan Gregório Bem <geyslan@...il.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	schumaker.anna@...il.com, linux-nfs@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-br <kernel-br@...glegroups.com>,
	"Geyslan G. Bem" <geyslan@...il.com>
Subject: Re: [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function

2013/10/14 Geyslan G. Bem <geyslan@...il.com>:
> Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  fs/nfs/callback.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 67cd732..073b4cf 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -164,8 +164,7 @@ nfs41_callback_up(struct svc_serv *serv)
>                 svc_xprt_put(serv->sv_bc_xprt);
>                 serv->sv_bc_xprt = NULL;
>         }
> -       dprintk("--> %s return %ld\n", __func__,
> -               IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0);
> +       dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
>         return rqstp;
>  }
>
> --
> 1.8.4
>
In this version (v2):
Format changed from %ld to %d.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/