linux-kernel - Re: [PATCH v2] nfs: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Oct 2013 17:33:17 -0300
From:	Geyslan Gregório Bem <geyslan@...il.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	schumaker.anna@...il.com, linux-nfs@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-br <kernel-br@...glegroups.com>,
	"Geyslan G. Bem" <geyslan@...il.com>
Subject: Re: [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c'

2013/10/14 Geyslan G. Bem <geyslan@...il.com>:
> Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  fs/nfs/nfs4super.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c
> index e26acdd..65ab0a0 100644
> --- a/fs/nfs/nfs4super.c
> +++ b/fs/nfs/nfs4super.c
> @@ -261,9 +261,9 @@ struct dentry *nfs4_try_mount(int flags, const char *dev_name,
>
>         res = nfs_follow_remote_path(root_mnt, export_path);
>
> -       dfprintk(MOUNT, "<-- nfs4_try_mount() = %ld%s\n",
> -                       IS_ERR(res) ? PTR_ERR(res) : 0,
> -                       IS_ERR(res) ? " [error]" : "");
> +       dfprintk(MOUNT, "<-- nfs4_try_mount() = %d%s\n",
> +                PTR_ERR_OR_ZERO(res),
> +                IS_ERR(res) ? " [error]" : "");
>         return res;
>  }
>
> @@ -319,9 +319,9 @@ static struct dentry *nfs4_referral_mount(struct file_system_type *fs_type,
>         data->mnt_path = export_path;
>
>         res = nfs_follow_remote_path(root_mnt, export_path);
> -       dprintk("<-- nfs4_referral_mount() = %ld%s\n",
> -                       IS_ERR(res) ? PTR_ERR(res) : 0,
> -                       IS_ERR(res) ? " [error]" : "");
> +       dprintk("<-- nfs4_referral_mount() = %d%s\n",
> +               PTR_ERR_OR_ZERO(res),
> +               IS_ERR(res) ? " [error]" : "");
>         return res;
>  }
>
> --
> 1.8.4
>

In this version (v2):
Format changed from %ld to %d.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/