linux-kernel - Re: [PATCH 2/3] ARM: at91/dt/trivial: before sama5d3, Atmel MPU were using at91 prefix

Open Source and information security mailing list archives

Date:	Tue, 15 Oct 2013 10:14:22 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	<linux-arm-kernel@...ts.infradead.org>, <ebenard@...rea.com>,
	<herbert@...dor.apana.org.au>, <linux-kernel@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM: at91/dt/trivial: before sama5d3, Atmel MPU were
 using at91 prefix

On 14/10/2013 19:09, Jean-Christophe PLAGNIOL-VILLARD :
> On 18:46 Mon 14 Oct     , Nicolas Ferre wrote:
>> Change the sha/aes/tdes compatibility string to match common
>> case for the at91sam9g45 family which is to keep the at91 prefix.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
>> ---
>>   arch/arm/boot/dts/sama5d3.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
>> index b2aabff..99bd4a6 100644
>> --- a/arch/arm/boot/dts/sama5d3.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3.dtsi
>> @@ -342,19 +342,19 @@
>>   			};
>>
>>   			sha@...34000 {
>> -				compatible = "atmel,sam9g46-sha";
>> +				compatible = "atmel,at91sam9g46-sha";
>>   				reg = <0xf8034000 0x100>;
>>   				interrupts = <42 IRQ_TYPE_LEVEL_HIGH 0>;
>>   			};
>>
>>   			aes@...38000 {
>> -				compatible = "atmel,sam9g46-aes";
>> +				compatible = "atmel,at91sam9g46-aes";
>>   				reg = <0xf8038000 0x100>;
>>   				interrupts = <43 IRQ_TYPE_LEVEL_HIGH 0>;
>>   			};
>>
>>   			tdes@...3c000 {
>> -				compatible = "atmel,sam9g46-tdes";
>> +				compatible = "atmel,at91sam9g46-tdes";
>>   				reg = <0xf803c000 0x100>;
>>   				interrupts = <44 IRQ_TYPE_LEVEL_HIGH 0>;
> you keep the previous compatible in the driver too for backword compatiblity

No, as the consumer of the old compatibility string has never been sent 
to mainline (or even mailing-list) and as the "dma" property is not 
compatible with the one existing on our 3.6.9-based kernel.

So, anyway the DT has to be changed for a move from 3.6.9 => 3.10. As I 
do not want to bloat the DT forever, let's stick with this new 
compatibility string.

Bye,

>>   			};
>> --
>> 1.8.2.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives