linux-kernel - Re: [PATCH 1/6] net: ip4_datagram_connect: Use correct form of statistics update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131016060932.GA21041@gmail.com>
Date:	Wed, 16 Oct 2013 08:09:32 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Christoph Lameter <cl@...ux.com>, Tejun Heo <tj@...nel.org>,
	akpm@...uxfoundation.org, rostedt@...dmis.org,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eric Dumazet <edumazet@...gle.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 1/6] net: ip4_datagram_connect: Use correct form of
 statistics update


* Eric Dumazet <eric.dumazet@...il.com> wrote:

> On Tue, 2013-10-15 at 12:47 -0500, Christoph Lameter wrote:
> > plain text document attachment (fix_snmp)
> > ip4_datagram_connect is called with BH processing enabled. Therefore
> > we cannot use IP_INC_STATS_BH but must use IP_INC_STATS which disables
> > BH handling before incrementing the counter.
> > 
> > The following trace is triggered without this patch:
> 
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: netdev@...r.kernel.org
> > Cc: David Miller <davem@...emloft.net>
> > Signed-off-by: Christoph Lameter <cl@...ux.com>
> 
> Strange, I thought I already Acked it...
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Christoph, _please_ pick up people's Acked-by's in the future ... This is 
basic courtesy towards reviewers.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/