linux-kernel - Re: [PATCH v4 12/12] intel_mid: Moved board related code to a new file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525DE197.5040607@zytor.com>
Date:	Tue, 15 Oct 2013 17:45:11 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	David Cohen <david.a.cohen@...ux.intel.com>
CC:	mingo@...hat.com, tglx@...utronix.de, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@...ux.intel.com>
Subject: Re: [PATCH v4 12/12] intel_mid: Moved board related code to a new
 file

On 10/15/2013 04:53 PM, David Cohen wrote:
> On 10/15/2013 04:44 PM, H. Peter Anvin wrote:
>> On 10/15/2013 04:42 PM, David Cohen wrote:
>>>
>>> +#define intel_mid_sfi_dev(i)   \
>>> +        static const struct devs_id *__intel_mid_sfi_##i##_dev __used \
>>> +        __attribute__((__section__(".x86_intel_mid_dev.init"))) = &i
>>> +
>>
>> Any reason to not just call this "sfi_device()" or something similar?
>> "Intel MID SFI" seems a bit redundant...
> 
> I had the same though. But struct devs_id is defined by asm/intel-mid.h.
> This function is not meant to be used by any other user beside
> intel-mid.
> But I can change if you prefer.
> 

Hm, I guess it doesn't really matter.  After all, no other devices will
probably ever see SFI (we hope).

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/