linux-kernel - Re: [PATCH] x86 efi: efi reverve boot service fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Oct 2013 10:36:00 +0200
From:	Maarten Lankhorst <maarten.lankhorst@...onical.com>
To:	Matt Fleming <matt@...sole-pimps.org>,
	Dave Young <dyoung@...hat.com>
CC:	x86@...nel.org, linux-kernel@...r.kernel.org, mjg59@...f.ucam.org,
	hpa@...or.com, James.Bottomley@...senPartnership.com,
	vgoyal@...hat.com, linux-efi@...r.kernel.org
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix

op 16-10-13 10:07, Matt Fleming schreef:
> Also better include Maarten on Cc as the author of the code.
>
> On Wed, 16 Oct, at 03:11:22PM, Dave Young wrote:
>> typo, fix hpa's mail address..
>>
>> On 10/16/13 at 03:03pm, Dave Young wrote:
>>> Current code check boot service region with kernel text region by: 
>>> start+size >= __pa_symbol(_text)
>>> The end of the above region should be start + size - 1 instead.

Acked-by: Maarten Lankhorst <maarten.lankhorst@...onical.com>

>>> I see this problem in ovmf + Fedora 19 grub boot:
>>> text start: 1000000 md start: 800000 md size: 800000
>>>
>>> Signed-off-by: Dave Young <dyoung@...hat.com>
>>> ---
>>>  arch/x86/platform/efi/efi.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-2.6.orig/arch/x86/platform/efi/efi.c
>>> +++ linux-2.6/arch/x86/platform/efi/efi.c
>>> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
>>>  		 * - Not within any part of the kernel
>>>  		 * - Not the bios reserved area
>>>  		*/
>>> -		if ((start+size >= __pa_symbol(_text)
>>> +		if ((start + size - 1 >= __pa_symbol(_text)
>>>  				&& start <= __pa_symbol(_end)) ||
>>>  			!e820_all_mapped(start, start+size, E820_RAM) ||
>>>  			memblock_is_region_reserved(start, size)) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/