lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20131017121215.826ab6cced73118f3dba8d4f@linux-foundation.org>
Date:	Thu, 17 Oct 2013 12:12:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Joe Perches <joe@...ches.com>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Michal Hocko <mhocko@...e.cz>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [bug] get_maintainer.pl incomplete output

On Wed, 16 Oct 2013 20:51:18 -0700 (PDT) David Rientjes <rientjes@...gle.com> wrote:

> I haven't looked closely at scripts/get_maintainer.pl, but I recently 
> wrote a patch touching mm/vmpressure.c and it doesn't list the file's 
> author, Anton Vorontsov <anton.vorontsov@...aro.org>.
> 
> Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is 
> missing and git blame attributs >90% of the lines to his authorship.
> 
> $ ./scripts/get_maintainer.pl -f mm/vmpressure.c 
> Tejun Heo <tj@...nel.org> (commit_signer:6/7=86%)
> Michal Hocko <mhocko@...e.cz> (commit_signer:5/7=71%)
> Andrew Morton <akpm@...ux-foundation.org> (commit_signer:4/7=57%)
> Li Zefan <lizefan@...wei.com> (commit_signer:3/7=43%)
> "Kirill A. Shutemov" <kirill@...temov.name> (commit_signer:1/7=14%)
> linux-mm@...ck.org (open list:MEMORY MANAGEMENT)
> linux-kernel@...r.kernel.org (open list)

get_maintainer should, by default, answer the question "who should I
email about this file".  It clearly isn't doing this, and that's a
pretty big fail.

I've learned not to trust it, so when I use it I always have to check
its homework with "git log | grep Author" :(

Joe, pretty please?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ