linux-kernel - Re: [bug] get_maintainer.pl incomplete output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Oct 2013 12:23:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Michal Hocko <mhocko@...e.cz>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [bug] get_maintainer.pl incomplete output

On Thu, 2013-10-17 at 12:12 -0700, Andrew Morton wrote:
> On Wed, 16 Oct 2013 20:51:18 -0700 (PDT) David Rientjes <rientjes@...gle.com> wrote:
> 
> > I haven't looked closely at scripts/get_maintainer.pl, but I recently 
> > wrote a patch touching mm/vmpressure.c and it doesn't list the file's 
> > author, Anton Vorontsov <anton.vorontsov@...aro.org>.
> > 
> > Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is 
> > missing and git blame attributs >90% of the lines to his authorship.
> > 
> > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c 
> > Tejun Heo <tj@...nel.org> (commit_signer:6/7=86%)
> > Michal Hocko <mhocko@...e.cz> (commit_signer:5/7=71%)
> > Andrew Morton <akpm@...ux-foundation.org> (commit_signer:4/7=57%)
> > Li Zefan <lizefan@...wei.com> (commit_signer:3/7=43%)
> > "Kirill A. Shutemov" <kirill@...temov.name> (commit_signer:1/7=14%)
> > linux-mm@...ck.org (open list:MEMORY MANAGEMENT)
> > linux-kernel@...r.kernel.org (open list)
> 
> get_maintainer should, by default, answer the question "who should I
> email about this file".  It clearly isn't doing this, and that's a
> pretty big fail.

I disagree.

It's decidedly good at doing precisely that when a
MAINTAINERS entry exists.

When no one is a listed maintainer, the results
can certainly be tweaked to be better.

> I've learned not to trust it, so when I use it I always have to check
> its homework with "git log | grep Author" :(
> 
> Joe, pretty please?

It's really a question of "how long ago is too long ago" as
older commits way too often also show old/invalid email
addresses.

I also don't want to wait over 30 seconds or so to find out
who is listed as a git signer/author by default.

Adding the commit listed "Author:" as a signer doesn't seem
too hard though.  I'll play with that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/