linux-kernel - Re: [PATCH 1/4] drivers/misc: add rawio framework driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131022054538.GB14163@kroah.com>
Date:	Tue, 22 Oct 2013 06:45:38 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Bin Gao <bin.gao@...ux.intel.com>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] drivers/misc: add rawio framework driver

On Mon, Oct 21, 2013 at 05:03:20PM -0700, Bin Gao wrote:
> Rawio provides a framework to read/write registers from a bus, including
> pci, i2c, I/O device(memory mapped), etc. based on debug fs.
> Rawio bus drivers implement the read/write operation on a specific bus
> on top of the rawio framework driver.
> They are designed to help device driver and kernel debugging on
> embedded systems.

Oh, one more technical thing, you totally fail to document the
user/kernel api you have just created.  You are parsing userspace data
in ways that I really don't understand at all...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/