linux-kernel - Re: [PATCH 1/4] drivers/misc: add rawio framework driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131022183246.GB53231@bingao-desk1.fm.intel.com>
Date:	Tue, 22 Oct 2013 11:32:46 -0700
From:	Bin Gao <bin.gao@...ux.intel.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] drivers/misc: add rawio framework driver

On Tue, Oct 22, 2013 at 06:45:38AM +0100, Greg Kroah-Hartman wrote:
> 
> Oh, one more technical thing, you totally fail to document the
> user/kernel api you have just created.

Yes, this is required to be done. Will fix it.

> You are parsing userspace data in ways that I really don't understand at all...

I don't know which specific codes you were talking about.
Overall the driver needs to parse each argument from the user command.
For example: "r iomem 0xff00c020 40", the driver needs parsing out:
r 		- read (and default width 4 bytes)
iomem		- I/O memory
0xff00c020	- the start address to read
40		- length to read	

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/