linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131023181525.GB23728@roeck-us.net>
Date:	Wed, 23 Oct 2013 11:15:25 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Michal Marek <mmarek@...e.cz>, haver@...ux.vnet.ibm.com,
	Frank Haverkamp <haver@...t.ibm.com>,
	linux-kernel@...r.kernel.org, arnd@...db.de,
	cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	utz.bacher@...ibm.com, jsvogt@...ibm.com, MIJUNG@...ibm.com,
	cascardo@...ux.vnet.ibm.com, michae@...per.es
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

On Wed, Oct 23, 2013 at 04:22:50PM +0100, Greg KH wrote:
> On Wed, Oct 23, 2013 at 05:06:41PM +0200, Michal Marek wrote:
> > On 23.10.2013 16:14, Frank Haverkamp wrote:
> > > of course you are right. Let me try again.
> > > 
> > > I hope this looks better now:
> > > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n",
> > > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx);
> > > ...
> 
> Also, _no_ driver should ever be doing this type of "hey, look at me,
> I'm now loaded!" type syslog spam anymore.  It's pointless, and should
> be abolished where ever possible.  That's one reason we have moved to
> the driver init type functions that make this impossible to do, and if
> possible, I recommend doing that here as well.
> 
I agree. Do we have that as a general policy written down somewhere ?
That would help in reviews with authors insisting that they absolutely
want such messages. 

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/