linux-kernel - Re: [PATCH 01/11] Export __smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131024101653.GV14598@kernel.dk>
Date:	Thu, 24 Oct 2013 11:16:53 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 01/11] Export __smp_call_function_single()

On Thu, Oct 24 2013, Christoph Hellwig wrote:
> On Thu, Oct 24, 2013 at 10:25:54AM +0100, Jens Axboe wrote:
> > The blk-mq core and the blk-mq null driver uses it.
> 
> Can't say I really like exporting it as all users will need a major
> ifdef mess.  If at all we'd expose the higher level add to llist and ipi
> abstraction that both blk-mq and the null_blk driver use.
> 
> For now I'd just suggest removing the NULL_IRQ_SOFTIRQ mode from
> null_blk and decouple that from blk-mq itself.  I'll try to cook up such
> an abstraction in the meantime.

Agree, lets get a proper interface exported for this from kernel/smp.c
instead. I've killed this patch and the softirq mode in null_blk for
now.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/