linux-kernel - Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52694B3F.5090008@linaro.org>
Date:	Thu, 24 Oct 2013 17:30:55 +0100
From:	Julien Grall <julien.grall@...aro.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	ian.campbell@...rix.com, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org
Subject: Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.

On 10/24/2013 03:49 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Oct 23, 2013 at 11:08:01PM +0100, Julien Grall wrote:
>>
>>
>> On 10/23/2013 05:15 PM, Konrad Rzeszutek Wilk wrote:
>>> On Sun, Oct 06, 2013 at 09:52:40PM +0100, Julien Grall wrote:
>> Actually, I looked closer the code, with the new solution
>> xen_raw_printk/xen_raw_console_write can't be call on ARM during
>> early init.
>>
>> On ARM, xen_domain_type is initialized during a core initcall. So
>> it's not possible to call the function before.
>
> OK, so won't work and won't harm. That is OK I think.

I use xen_raw_printk every time to debug early code and when someone has 
an issue with Linux (for instance no log in the console), we advise them 
to use xen_raw_printk.
It's annoying for every ARM developer to modify ourself the function 
each time we need it...

I'm sure the solution "move xen call earlier" will come up in few mails, 
so there was a discussion for swiotlb few weeks ago 
(https://lkml.org/lkml/2013/8/29/609). And the final decision was to 
avoid specific Xen call in arch_setup.

So I think, for now the best solution is to call unconditionally 
dom0_write_console on ARM (32 and 64 bits).

#ifdef CONFIG_X86
if (xen_domain) {
   ...
} else if (...) {
...
}
#else
    dom0_write_console
#endif

It will avoid to carry non-upstream patch for ARM and point out every 
time developer to this patch.

Stefano, Ian, any opinion?

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/