[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1382633034.22417.121.camel@hastur.hellion.org.uk>
Date: Thu, 24 Oct 2013 17:43:54 +0100
From: Ian Campbell <ian.campbell@...rix.com>
To: Julien Grall <julien.grall@...aro.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM
guests.
On Thu, 2013-10-24 at 17:30 +0100, Julien Grall wrote:
> I'm sure the solution "move xen call earlier" will come up in few mails,
> so there was a discussion for swiotlb few weeks ago
> (https://lkml.org/lkml/2013/8/29/609). And the final decision was to
> avoid specific Xen call in arch_setup.
It wasn't so much a hard reject as a preference based on the need
presented at the time.
Perhaps a generic DT driven mechanism to detect hypervisors, called
early, would be more acceptable?
> Stefano, Ian, any opinion?
The ifdef approach is a bit ugly, but if the other option doesn't work
out I suppose we can live with it.
But stepping back how/why is this function called on x86 when not
running under Xen? Wouldn't the use have to be using console=hvc or
earlyprintk=xen or something -- which strikes me as user error... IOW
can we not just nuke the check
Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists